Skip to content

Comments

Improve the selection/hover behavior for plots#5096

Merged
Wumpf merged 2 commits intomainfrom
jleibs/no_select_on_reset_plots
Feb 7, 2024
Merged

Improve the selection/hover behavior for plots#5096
Wumpf merged 2 commits intomainfrom
jleibs/no_select_on_reset_plots

Conversation

@jleibs
Copy link
Member

@jleibs jleibs commented Feb 7, 2024

What

Several changes to plots:

  • When resetting the plot, don't trigger a selection. Previously if an item ended up under the cursor after the reset, it would end up selected.
  • Additionally, when hovering/clicking the background of the plot, process hover/selection accordingly.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@jleibs jleibs requested a review from Wumpf February 7, 2024 15:22
@jleibs jleibs added 📺 re_viewer affects re_viewer itself enhancement New feature or request include in changelog labels Feb 7, 2024
@jleibs jleibs marked this pull request as ready for review February 7, 2024 15:22
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice, great test protocol

@teh-cmc
Copy link
Member

teh-cmc commented Feb 7, 2024

I'd go one step further and add a bullet point for pressing escape now that #5103 is in

@Wumpf Wumpf merged commit 70b3dd8 into main Feb 7, 2024
@Wumpf Wumpf deleted the jleibs/no_select_on_reset_plots branch February 7, 2024 15:51
@Wumpf
Copy link
Member

Wumpf commented Feb 7, 2024

ah shoot saw your comment too late @teh-cmc !

@teh-cmc
Copy link
Member

teh-cmc commented Feb 7, 2024

😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱

teh-cmc added a commit that referenced this pull request Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request include in changelog 📺 re_viewer affects re_viewer itself

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Double clicking plot background selects the first series

3 participants