Skip to content

Comments

Introduce a new component for MarkerShape and use it in SeriesPoint#5004

Merged
jleibs merged 6 commits intomainfrom
jleibs/point_markers
Feb 2, 2024
Merged

Introduce a new component for MarkerShape and use it in SeriesPoint#5004
jleibs merged 6 commits intomainfrom
jleibs/point_markers

Conversation

@jleibs
Copy link
Member

@jleibs jleibs commented Feb 1, 2024

What

  • Add new MarkerShape component
  • Register a component-editor for it
  • Use it in PointVisualizerSystem / TimeSeries space-view
  • Bump up the radius for the point visualizer system

image

TODO:

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@jleibs jleibs marked this pull request as ready for review February 1, 2024 21:29
@emilk emilk mentioned this pull request Feb 2, 2024
@jleibs jleibs added ui concerns graphical user interface 🟦 blueprint The data that defines our UI include in changelog labels Feb 2, 2024
@emilk emilk self-requested a review February 2, 2024 13:32
@emilk
Copy link
Member

emilk commented Feb 2, 2024

Is "marker" the standard word for this?

@jleibs
Copy link
Member Author

jleibs commented Feb 2, 2024

Is "marker" the standard word for this?

https://matplotlib.org/stable/api/markers_api.html
https://seaborn.pydata.org/tutorial/properties.html#marker
https://observablehq.com/plot/features/markers

@jleibs jleibs merged commit afca28b into main Feb 2, 2024
@jleibs jleibs deleted the jleibs/point_markers branch February 2, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🟦 blueprint The data that defines our UI include in changelog ui concerns graphical user interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants