Skip to content

Comments

Cached 2D & 3D box clouds#5000

Merged
teh-cmc merged 4 commits intomainfrom
cmc/cached_boxes
Feb 1, 2024
Merged

Cached 2D & 3D box clouds#5000
teh-cmc merged 4 commits intomainfrom
cmc/cached_boxes

Conversation

@teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Feb 1, 2024 •
edited by github-actions bot
Loading

The usual grunt work, nothing particularly exciting.

Comparison using the multithreading example with range -inf:+inf:

0.12.1:
image

Now:
image

This unearthed, and requires:

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@teh-cmc teh-cmc added 📉 performance Optimization, memory use, etc do-not-merge Do not merge this PR include in changelog labels Feb 1, 2024
@teh-cmc teh-cmc mentioned this pull request Feb 1, 2024
Merged
4 tasks
Base automatically changed from cmc/no_parallelism_in_attr_processors to main February 1, 2024 17:08
teh-cmc added a commit that referenced this pull request Feb 1, 2024
@teh-cmc
Remove parallel iterators in attribute processors (#4999)
4897b93 
At least on my machine, the parallel iterators that were recently added
to the attribute processing methods result in at least an order of
magnitude performance loss.

With `par_iter`:

![image](https://github.com/rerun-io/rerun/assets/2910679/f2bbcace-2965-4ecf-b35d-ff565c6b0d98)


Without `par_iter`:

![image](https://github.com/rerun-io/rerun/assets/2910679/2eda2b43-4ab9-418e-a596-3d36ebb03027)

(Screenshots taken from #5000)
@teh-cmc teh-cmc removed the do-not-merge Do not merge this PR label Feb 1, 2024
@Wumpf Wumpf self-requested a review February 1, 2024 17:31
Wumpf
Wumpf approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@teh-cmc teh-cmc merged commit a0b77fe into main Feb 1, 2024
@teh-cmc teh-cmc deleted the cmc/cached_boxes branch February 1, 2024 18:36
@teh-cmc teh-cmc changed the title Integrate caching in 2D and 3D box visualizers Cached 2D & 3D box clouds Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees

No one assigned

Labels

include in changelog 📉 performance Optimization, memory use, etc

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@teh-cmc @Wumpf