Skip to content

Rename StoreDb to EntityDb, re_data_store -> re_entity_db#4670

Merged
emilk merged 4 commits into
mainfrom
emilk/rename-store-db
Jan 4, 2024
Merged

Rename StoreDb to EntityDb, re_data_store -> re_entity_db#4670
emilk merged 4 commits into
mainfrom
emilk/rename-store-db

Conversation

@emilk
Copy link
Copy Markdown
Member

@emilk emilk commented Jan 4, 2024

What

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@emilk emilk added 🚜 refactor Change the code, not the functionality exclude from changelog PRs with this won't show up in CHANGELOG.md include in changelog and removed exclude from changelog PRs with this won't show up in CHANGELOG.md labels Jan 4, 2024
@emilk emilk changed the title Rename StoreDb to EntityDb Rename StoreDb to EntityDb, re_data_store -> re_entity_db Jan 4, 2024
@Wumpf Wumpf self-requested a review January 4, 2024 10:42
Copy link
Copy Markdown
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. let's merge asap :)

@Wumpf
Copy link
Copy Markdown
Member

Wumpf commented Jan 4, 2024

https://docs.rs/re_entity_db needs to be a speculative link

@emilk emilk merged commit a284fd6 into main Jan 4, 2024
@emilk emilk deleted the emilk/rename-store-db branch January 4, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

include in changelog 🚜 refactor Change the code, not the functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants