Local-first wheel publishing#4454
Merged
Merged
Conversation
jprochazk
added
🧑💻 dev experience
abey79
reviewed
Dec 7, 2023
jleibs
approved these changes
Dec 11, 2023
Contributor
jleibs
left a comment
jleibs
left a comment
There was a problem hiding this comment.
This looks nice (assuming it works).
Comment on lines
150
to
+155
| - name: Save wheel artifact | ||
| if: ${{ inputs.WHEEL_ARTIFACT_NAME != '' }} | ||
| uses: actions/upload-artifact@v3 | ||
| with: | ||
| name: ${{inputs.WHEEL_ARTIFACT_NAME}} | ||
| path: dist | ||
| path: dist/${{ needs.set-config.outputs.TARGET }} |
Contributor
There was a problem hiding this comment.
Does anything use the intermediate github artifact now, or can this go away with everything just using gcloud?
Member
Author
There was a problem hiding this comment.
there are jobs using it still, but it's possible to remove it altogether. would like to leave that for another PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Based on #4275
Part of #4169
Checklist