Conversation
jprochazk
added
🕸️ web
emilk
left a comment
emilk
left a comment
There was a problem hiding this comment.
Looks good overall, but I don't understand why there are two links in the new PR description template
.github/pull_request_template.md
Outdated
| * [ ] I have tested the web demo (if applicable): | ||
| * [Nightly](https://app.rerun.io/pr/{{ pr.number }}/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) | ||
| * [PR](https://app.rerun.io/pr/{{ pr.number }}/index.html) |
There was a problem hiding this comment.
This needs to be elaborated on. As it reads now I would assume the first link would test the nightly version of the viewer, which makes little sense.
Both are using the viewer from this PR afaict, but the first one links to example rrds from the "nightly" build, and the second one links to examples from… what exactly?
There was a problem hiding this comment.
I tried to add some more information here
| }); | ||
|
|
||
| self.examples.iter().for_each(|example| { | ||
| for example in examples { |
There was a problem hiding this comment.
👍 - it's a bit surprising that clippy::needless_for_each doesn't catch this
There was a problem hiding this comment.
I'm not sure what I changed, but at some point while I was working on this, the lint finally popped up which prompted me to change this
|
I pulled in an unrelated change, prettier v3 expects lowercase |
2 participants
What
examples_manifest.jsonas part of the binary in favor of downloading it fromapp.rerun.iore_viewer/build.rslogic to a separate binary cratemanifest_url)examples_manifest.jsontogether with every build of the web app for:/commit/pr/version/nightly/version/{tag}/prerelease/latestChecklist