Update Rust to 1.74.0#4390
Merged
Merged
Conversation
Wumpf
added
dependencies
4 tasks
emilk
approved these changes
Nov 30, 2023
Member
emilk
left a comment
emilk
left a comment
There was a problem hiding this comment.
I'm looking forward to turning on more clippy lints!
Member
Author
Ah right. I wasn't fully aware that many clippy lints are opt-in. Like the one I pointed out. Taking that separately |
5 tasks
emilk
pushed a commit
that referenced
this pull request
Feb 14, 2024
…amples (#5195) ### What The last rust update in * #4390 didn't catch a whole bunch of places. ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using newly built examples: [app.rerun.io](https://app.rerun.io/pr/5195/index.html) * Using examples from latest `main` build: [app.rerun.io](https://app.rerun.io/pr/5195/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [app.rerun.io](https://app.rerun.io/pr/5195/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! - [PR Build Summary](https://build.rerun.io/pr/5195) - [Docs preview](https://rerun.io/preview/7ac1616173ee2d5da35c31ea3617e3146e2f6a2e/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/7ac1616173ee2d5da35c31ea3617e3146e2f6a2e/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Wumpf
added a commit
that referenced
this pull request
Feb 21, 2024
…amples (#5195) ### What The last rust update in * #4390 didn't catch a whole bunch of places. ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using newly built examples: [app.rerun.io](https://app.rerun.io/pr/5195/index.html) * Using examples from latest `main` build: [app.rerun.io](https://app.rerun.io/pr/5195/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [app.rerun.io](https://app.rerun.io/pr/5195/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! - [PR Build Summary](https://build.rerun.io/pr/5195) - [Docs preview](https://rerun.io/preview/7ac1616173ee2d5da35c31ea3617e3146e2f6a2e/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/7ac1616173ee2d5da35c31ea3617e3146e2f6a2e/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
I'm mostly after
needless_pass_by_ref_mutlint (added in 1.73.0) which didn't even trigger so far 😮. But useful for my current stream of work of making things more interior mutable.Checklist