Skip to content

Comments

Fix inaccessible entities being incorrectly added to space view#4226

Merged
jleibs merged 1 commit intomainfrom
jleibs/dont_visit_disconnected
Nov 14, 2023
Merged

Fix inaccessible entities being incorrectly added to space view#4226
jleibs merged 1 commit intomainfrom
jleibs/dont_visit_disconnected

Conversation

@jleibs
Copy link
Member

@jleibs jleibs commented Nov 14, 2023

What

Although is_reachable_by_transform correctly accounts for disconnected spaces, visit_descendants_with_reachable_transform was never modified to account for disconnected spaces correctly. The inconsistency leads to creating a space with unreachable content in it.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested demo.rerun.io (if applicable)
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@jleibs jleibs marked this pull request as ready for review November 14, 2023 13:57
@Wumpf Wumpf self-requested a review November 14, 2023 14:13
@jleibs jleibs added 🪳 bug Something isn't working include in changelog labels Nov 14, 2023
@jleibs jleibs changed the title Skip disconnected spaces in visit_descendants_with_reachable_transform Fix inaccessible entities from being incorrectly added to store view Nov 14, 2023
@jleibs jleibs changed the title Fix inaccessible entities from being incorrectly added to store view Fix inaccessible entities being incorrectly added to store view Nov 14, 2023
@jleibs jleibs changed the title Fix inaccessible entities being incorrectly added to store view Fix inaccessible entities being incorrectly added to space view Nov 14, 2023
@jleibs jleibs merged commit 6a96d0d into main Nov 14, 2023
@jleibs jleibs deleted the jleibs/dont_visit_disconnected branch November 14, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🪳 bug Something isn't working include in changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Broken space view added by heuristics

2 participants