Merged
Conversation
Wumpf
reviewed
Oct 17, 2023
rerun_py/pyproject.toml
Outdated
| # https://docs.python.org/3/library/warnings.html#warning-filter | ||
| filterwarnings = """ | ||
| error | ||
| ignore::pytest.PytestUnraisableExceptionWarning |
Member
There was a problem hiding this comment.
any more context why this one is ignored?
Member
Author
There was a problem hiding this comment.
The context is that I've been lazy and discarded this error as what I initially (mis-)read as some internal Pytest stuff. It turns out they were caused by two nasty instance of us not closing files properly, which I now fixed.
Thanks for not letting me be lazy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This PR configures pytest such that it fails if a warning is emitted (e.g. a deprecation warning).
pyproject.toml-c path/to/pyproject.tomlin pytest invocations (justfileand CI)Checklist