Add warning in the Quick Start guides about Safari breaking Copy to Clipboard#3898
Merged
Add warning in the Quick Start guides about Safari breaking Copy to Clipboard#3898
Conversation
emilk
approved these changes
Oct 17, 2023
Comment on lines
352
to
359
| #[cfg(target_arch = "wasm32")] | ||
| let result = web_sys::window()?.navigator().user_agent().ok(); | ||
|
|
||
| #[cfg(not(target_arch = "wasm32"))] | ||
| let result = None; | ||
|
|
||
| result | ||
| } |
Member
There was a problem hiding this comment.
Suggested change
| #[cfg(target_arch = "wasm32")] | |
| let result = web_sys::window()?.navigator().user_agent().ok(); | |
| #[cfg(not(target_arch = "wasm32"))] | |
| let result = None; | |
| result | |
| } | |
| #[cfg(target_arch = "wasm32")] | |
| eframe::web::user_agent() | |
| #[cfg(not(target_arch = "wasm32"))] | |
| None | |
| } |
Member
Author
There was a problem hiding this comment.
This is the most compact I can think of:
fn user_agent() -> Option<String> {
#[cfg(target_arch = "wasm32")]
return eframe::web::user_agent();
#[cfg(not(target_arch = "wasm32"))]
None
}Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What
For security reason, Safari doesn't let use copy text from our Web viewer, see:
This PR detects if we are running on Safari and adds a warning to the top of the Quick Start guides.
Checklist