Conversation
Member
Wumpf
approved these changes
Oct 16, 2023
Member
Wumpf
left a comment
There was a problem hiding this comment.
mostly only looked at toml and md files
I like where this is going: This should also make python and rerun_c a lot smaller once re_sdk is free of built-in types other than re_types_core 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR introduces a new crate:
re_types_core.re_types_coreonly contains the fundamental traits and types that make up Rerun's data model.It is split off from the existing
re_types.This makes it possible to work with our data model abstractions without having to depend on the
re_typesbehemoth.This is more than a DX improvement: since so many things depend directly or indirectly on
re_types, it is very easy to end-up with unsolvable dependency cycles. This helps with that in some cases (though certainly not all).In particular,
re_tuid(and by extensionre_format) are now completely free ofre_types.For convenience,
re_typesreexports all ofre_types_core, so the public API looks unchanged.In a handful of instances (
re_arrow_store,re_data_store,re_log_types,re_query), I've went the extra mile and started porting these crates towards rawre_types_corerather than relying on the reexports.The reason is that, upon closer inspection, these crates are very close to being able to live free of
re_types. In the future, the custom crate and custom module attributes coming with #3741 might allow us to make these independent.Similarly, the codegen now uses
re_types_coredirectly, as that makes the life of the upcoming "serde-codegen" work much easier.What
Checklist