Skip to content

Refactor rerun.AnyValues to handle None input more gracefully#3725

Merged
abey79 merged 9 commits into
mainfrom
jleibs/forgiving_any_values
Oct 9, 2023
Merged

Refactor rerun.AnyValues to handle None input more gracefully#3725
abey79 merged 9 commits into
mainfrom
jleibs/forgiving_any_values

Conversation

@jleibs
Copy link
Copy Markdown
Contributor

@jleibs jleibs commented Oct 6, 2023

What

  • Rename _send_warning -> _send_warning_or_raise to make the behavior clearer.
  • Default to ignore Nones in AnyValues when the type is unknown.
  • Update the docstrings.
  • Expand the unit-tests.

Resolves:

Checklist

@jleibs jleibs marked this pull request as ready for review October 6, 2023 16:13
@jleibs jleibs added this to the 0.9.1 milestone Oct 6, 2023
Copy link
Copy Markdown
Member

@abey79 abey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@abey79 abey79 changed the title Refactor AnyValues to handle Nones more gracefully Refactor rerun.AnyValues to handle None` input more gracefully Oct 9, 2023
@abey79 abey79 merged commit 1a78cb7 into main Oct 9, 2023
@abey79 abey79 deleted the jleibs/forgiving_any_values branch October 9, 2023 07:52
@emilk emilk changed the title Refactor rerun.AnyValues to handle None` input more gracefully Refactor rerun.AnyValues to handle None input more gracefully Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants