Normalize quaternions#3094
Merged
Merged
Conversation
jleibs
force-pushed
the
jleibs/normalize_quaternions
branch
from
2df28af to
6b0a918
Compare
jleibs
force-pushed
the
jleibs/normalize_quaternions
branch
from
8b348e6 to
596b11c
Compare
Wumpf
approved these changes
Aug 24, 2023
jleibs
added a commit
that referenced
this pull request
Aug 31, 2023
Without normalizing quaternions, the cameras.rs scene part could end up determining that a quaternion is not iso, resulting in unexpextedly failing to show the view frustum. * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/3094) (if applicable) - [PR Build Summary](https://build.rerun.io/pr/3094) - [Docs preview](https://rerun.io/preview/596b11c21a3d8470ddba00d4c24aef965b45869a/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/596b11c21a3d8470ddba00d4c24aef965b45869a/examples) <!--EXAMPLES-PREVIEW--><!--EXAMPLES-PREVIEW--><!--EXAMPLES-PREVIEW--><!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://ref.rerun.io/dev/bench/) - [Wasm size tracking](https://ref.rerun.io/dev/sizes/)
jleibs
added a commit
that referenced
this pull request
Aug 31, 2023
Without normalizing quaternions, the cameras.rs scene part could end up determining that a quaternion is not iso, resulting in unexpextedly failing to show the view frustum. * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/3094) (if applicable) - [PR Build Summary](https://build.rerun.io/pr/3094) - [Docs preview](https://rerun.io/preview/596b11c21a3d8470ddba00d4c24aef965b45869a/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/596b11c21a3d8470ddba00d4c24aef965b45869a/examples) <!--EXAMPLES-PREVIEW--><!--EXAMPLES-PREVIEW--><!--EXAMPLES-PREVIEW--><!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://ref.rerun.io/dev/bench/) - [Wasm size tracking](https://ref.rerun.io/dev/sizes/)
jleibs
added a commit
that referenced
this pull request
Aug 31, 2023
Without normalizing quaternions, the cameras.rs scene part could end up determining that a quaternion is not iso, resulting in unexpextedly failing to show the view frustum. * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/3094) (if applicable) - [PR Build Summary](https://build.rerun.io/pr/3094) - [Docs preview](https://rerun.io/preview/596b11c21a3d8470ddba00d4c24aef965b45869a/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/596b11c21a3d8470ddba00d4c24aef965b45869a/examples) <!--EXAMPLES-PREVIEW--><!--EXAMPLES-PREVIEW--><!--EXAMPLES-PREVIEW--><!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://ref.rerun.io/dev/bench/) - [Wasm size tracking](https://ref.rerun.io/dev/sizes/)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Without normalizing quaternions, the cameras.rs scene part could end up determining that a quaternion is not iso, resulting in unexpextedly failing to show the view frustum.
Checklist