More eager GC, and remove --fast-math optimization for wasm#1656
Merged
Conversation
emilk
added
📺 re_viewer
Wumpf
approved these changes
Mar 21, 2023
Member
Wumpf
left a comment
Wumpf
left a comment
There was a problem hiding this comment.
lgtm! But can you please edit the title to be easy to digest for release notes?
emilk
changed the title
--fast-math optimization for wasm
1 task
emilk
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few things I found in
git stash pop. The commit messages should describe them all pretty well.Checklist