Conversation
teh-cmc
commented
Mar 2, 2023
teh-cmc
added
ui
teh-cmc
commented
Mar 2, 2023
Wumpf
approved these changes
Mar 2, 2023
Member
Wumpf
left a comment
Wumpf
left a comment
There was a problem hiding this comment.
looks all very clean!
(I haven't compared impls or even verified them ;))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
re_rendererso that everything can benefit without having to importre_viewerDefinitely don't review by on a commit-by-commit basis: they don't make sense, most of them have been salvaged by cherry picking from my gazillon local branches
PR will follow shortly which integrates these with depth clouds.