Analytics: add event for when we serve the web-viewer .wasm#1379
Merged
Analytics: add event for when we serve the web-viewer .wasm#1379
Conversation
emilk
changed the title
serve_wasm analytics event when serving a .wasm file
teh-cmc
approved these changes
Feb 22, 2023
emilk
added a commit
that referenced
this pull request
Mar 2, 2023
* Serve a `serve_wasm` analytics event when serving a .wasm file * silence warning on CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Can be tested with
cargo r -p objectron -- --serveIt's extremely bare-bones, but will give us a hint of how popular this feature is:
Closes #396
Checklist
CHANGELOG.md(if this is a big enough change to warrant it)