Conversation
emilk
reviewed
Feb 14, 2023
|
|
||
| if indices is not None: | ||
| indices = indices.flatten().astype(np.uint32) | ||
| indices = np.asarray(indices, dtype=np.uint32).flatten() |
Member
There was a problem hiding this comment.
What is the difference here? Does it now accept normal arrays where it before didn't?
I'm kind of vary of doing actual code changes this close to release
Contributor
Author
There was a problem hiding this comment.
Exactly, it accepts np.array([..]) as well as [..]
There was a problem hiding this comment.
sudo tar -vcfz dvr_rdk_v1.tar.gz dvr_rdk/
add this to tar and APT plays into action than
awalsh128/cache-apt-pkgs-action#98
link would help you about the new version update asap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
CHANGELOG.md(if this is a big enough change to warrant it)