Skip to content

Comments

Update log_mesh and log_meshes docs.#1286

Merged
Wumpf merged 1 commit intomainfrom
john/docs_check2
Feb 28, 2023
Merged

Update log_mesh and log_meshes docs.#1286
Wumpf merged 1 commit intomainfrom
john/docs_check2

Conversation

@jondo2010
Copy link
Contributor

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I've added a line to CHANGELOG.md (if this is a big enough change to warrant it)

@jondo2010 jondo2010 added the sdk-python Python logging API label Feb 14, 2023
@emilk emilk added the 📖 documentation Improvements or additions to documentation label Feb 14, 2023

if indices is not None:
indices = indices.flatten().astype(np.uint32)
indices = np.asarray(indices, dtype=np.uint32).flatten()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the difference here? Does it now accept normal arrays where it before didn't?

I'm kind of vary of doing actual code changes this close to release

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly, it accepts np.array([..]) as well as [..]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sudo tar -vcfz dvr_rdk_v1.tar.gz dvr_rdk/
add this to tar and APT plays into action than

awalsh128/cache-apt-pkgs-action#98
link would help you about the new version update asap

@emilk emilk added the do-not-merge Do not merge this PR label Feb 14, 2023
@jondo2010 jondo2010 removed the do-not-merge Do not merge this PR label Feb 17, 2023
@Wumpf Wumpf merged commit a853700 into main Feb 28, 2023
@Wumpf Wumpf deleted the john/docs_check2 branch February 28, 2023 14:09
emilk pushed a commit that referenced this pull request Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📖 documentation Improvements or additions to documentation sdk-python Python logging API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants