Catch keyboard interrupt in rerun-sdk CLI and return exit codes#12496
Catch keyboard interrupt in rerun-sdk CLI and return exit codes#12496rerun-sync[bot] merged 3 commits intomainfrom
rerun-sdk CLI and return exit codes#12496Conversation
|
|
|
What's the status of this PR? |
|
Blocked by a side-effect, discovering that e2e test is broken. See https://rerunio.slack.com/archives/C045J1Z7DU7/p1768582805102949?thread_ts=1768581103.390639&cid=C045J1Z7DU7 |
bd321e1 to
9d7d9e1
Compare
|
Web viewer built successfully.
View image diff on kitdiff. Note: This comment is updated whenever you push a commit. |
| re_log::info!( | ||
| "Timed out after successfully receiving {num_messages} messages. Assuming the client disconnected cleanly.", | ||
| ); | ||
| return Ok(db); |
There was a problem hiding this comment.
This is the workaround for the test. The rest of the diff is due to a "unnecessary match statement" clippy lint.
There was a problem hiding this comment.
note: this function is only for the e2e test, see comment above
|
@rerun-bot reality-sync |
|
Sync complete. Mirror PR in reality: https://github.com/rerun-io/reality/pull/209 Triggered by @MichaelGrupp |
Fixes two issues:
main()function weren't returned to the OS by the executable.KeyboardInterruptrerun-sdkand terminatererunwith ctrl+c, there was an ugly traceback..now: