Skip to content

Comments

Fix bad error reporting when registering a (faulty) RRD URI built from a relative path#12309

Merged
abey79 merged 6 commits intomainfrom
antoine/rr-3234-fix-relative-uri-error
Jan 6, 2026
Merged

Fix bad error reporting when registering a (faulty) RRD URI built from a relative path#12309
abey79 merged 6 commits intomainfrom
antoine/rr-3234-fix-relative-uri-error

Conversation

@abey79
Copy link
Member

@abey79 abey79 commented Jan 5, 2026

Related

What

Sticking "file:// in front of a relative path is a footgun, because the resulting URI is valid, but the first path element is considered a hostname (uri in the form of file://hostname/path/to/file.txt). These were previously accepted by /RegisterWithDataset and silently dropped by the OSS server.

This PR:

  • hardens the URI handling in OSS server
  • adds a redap test to ensure not_found errors are returned for bad URIs

@github-actions
Copy link

github-actions bot commented Jan 5, 2026

Web viewer built successfully.

Result Commit Link Manifest
359506d https://rerun.io/viewer/pr/12309 +nightly +main

View image diff on kitdiff.

Note: This comment is updated whenever you push a commit.

@ntjohnson1 ntjohnson1 added the consider-patch PRs & issues that should be considered to be cherry-picked to a patch release branch. label Jan 5, 2026
@abey79 abey79 merged commit 5de4d57 into main Jan 6, 2026
40 checks passed
@abey79 abey79 deleted the antoine/rr-3234-fix-relative-uri-error branch January 6, 2026 09:49
@grtlr
Copy link
Member

grtlr commented Jan 9, 2026

I've removed the consider-patch label as per our discussion.

@grtlr grtlr removed the consider-patch PRs & issues that should be considered to be cherry-picked to a patch release branch. label Jan 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants