Add option to specify target_frame to SpatialInformation#12040
Merged
Conversation
grtlr
added
📺 re_viewer
|
Latest documentation preview deployed successfully.
Note: This comment is updated whenever you push a commit. |
|
Web viewer built successfully.
View image diff on kitdiff. Note: This comment is updated whenever you push a commit. |
grtlr
force-pushed
the
grtlr/tf/space-origin
branch
from
9a6782d to
1843e70
Compare
Member
|
screenshot plz :) |
grtlr
force-pushed
the
grtlr/tf/space-origin
branch
from
1843e70 to
01d0063
Compare
Wumpf
requested changes
Dec 2, 2025
Member
Wumpf
left a comment
Wumpf
left a comment
There was a problem hiding this comment.
I think we can make this fallback situation still better. If not then we should at least document here why we can't and why this is the best non-insane solution :)
crates/store/re_types/definitions/rerun/blueprint/archetypes/spatial_information.fbs
Outdated
Show resolved
Hide resolved
grtlr
force-pushed
the
grtlr/tf/space-origin
branch
2 times, most recently
from
78fa9b2 to
a7e3f34
Compare
Wumpf
approved these changes
Dec 3, 2025
Member
There was a problem hiding this comment.
this snapshot needs more space now
grtlr
force-pushed
the
grtlr/tf/space-origin
branch
6 times, most recently
from
97ec587 to
65a366f
Compare
grtlr
force-pushed
the
grtlr/tf/space-origin
branch
from
65a366f to
c072a81
Compare
grtlr
force-pushed
the
grtlr/tf/space-origin
branch
from
c072a81 to
a4ebd3c
Compare
Wumpf
reviewed
Dec 3, 2025
Member
Wumpf
left a comment
Wumpf
left a comment
There was a problem hiding this comment.
nice! after the fact this didn't look so bad indeed 😄
Comment on lines
140
to
144
| ctx: &ViewerContext<'_>, | ||
| ui: &mut egui::Ui, | ||
| state: &mut dyn ViewState, | ||
| _space_origin: &EntityPath, | ||
| space_origin: &EntityPath, | ||
| view_id: ViewId, |
Member
There was a problem hiding this comment.
ha, almost like this should be a view ctx.
(for another day ofc ;-))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related
What
This PR adds
target_frameview property to theSpatialInformationarchetype.To this this PR open the DNA example and enter
tf#/helix/structureinto thetarget_framefield of the view. Now only the beads should be animated when pressing play.