Skip to content

Comments

Fix non semver compliant breaking changes in ply-rs breaking Rust builds#11890

Merged
IsseW merged 5 commits intomainfrom
cmc/bruh
Nov 14, 2025
Merged

Fix non semver compliant breaking changes in ply-rs breaking Rust builds#11890
IsseW merged 5 commits intomainfrom
cmc/bruh

Conversation

@teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Nov 13, 2025

Make sure we can compile with all 2.0.x versions of ply-rs out there.

See https://rerunio.slack.com/archives/C095BFLA4V6/p1763051394591979.

@teh-cmc teh-cmc added 🪳 bug Something isn't working ⛴ release Related to shipping or publishing dependencies concerning crates, pip packages etc include in changelog labels Nov 13, 2025
@github-actions
Copy link

github-actions bot commented Nov 13, 2025

Web viewer built successfully.

Result Commit Link Manifest
5443d5e https://rerun.io/viewer/pr/11890 +nightly +main

View image diff on kitdiff.

Note: This comment is updated whenever you push a commit.

Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@teh-cmc
Copy link
Member Author

teh-cmc commented Nov 13, 2025

Those deny failures seem completely unrelated, wtf

@IsseW IsseW merged commit 349f8c7 into main Nov 14, 2025
68 of 70 checks passed
@IsseW IsseW deleted the cmc/bruh branch November 14, 2025 10:22
@IsseW IsseW added the consider-patch PRs & issues that should be considered to be cherry-picked to a patch release branch. label Nov 14, 2025
IsseW added a commit that referenced this pull request Nov 14, 2025
…uilds (#11890)

Make sure we can compile with all 2.0.x versions of `ply-rs` out there.

See https://rerunio.slack.com/archives/C095BFLA4V6/p1763051394591979.

---------

Co-authored-by: Isse <git@isse.rs>
@IsseW IsseW removed the consider-patch PRs & issues that should be considered to be cherry-picked to a patch release branch. label Nov 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🪳 bug Something isn't working dependencies concerning crates, pip packages etc include in changelog ⛴ release Related to shipping or publishing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants