Fix broken delete_entries and entries table not updated#11872
Merged
Conversation
|
Web viewer built successfully.
View image diff on kitdiff. Note: This comment is updated whenever you push a commit. |
abey79
added
🪳 bug
IsseW
approved these changes
Nov 12, 2025
Member
IsseW
left a comment
IsseW
left a comment
There was a problem hiding this comment.
Can't see any obvious issues, so approved!
| self.update_entries_table() | ||
| } | ||
|
|
||
| pub fn create_dataset( |
Member
There was a problem hiding this comment.
I feel like these probably should have doc comments? But not required here as this is mostly a moved function
IsseW
pushed a commit
that referenced
this pull request
Nov 12, 2025
IsseW
removed
the
consider-patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
I noticed that the entries table wasn't updated when dataset are created and deleted. This PR fixes this.
One thing leading to another, I also discovered that
delete_entrywas utterly broken:Both fixed too.
Note: new test checked to be passing with
dataplatformmain.