Fix dataframe queries failing on empty datasets#11846
Merged
ntjohnson1 merged 4 commits intomainfrom Nov 10, 2025
Merged
Conversation
abey79
added
include in changelog
🪳 bug
|
Web viewer built successfully.
View image diff on kitdiff. Note: This comment is updated whenever you push a commit. |
andrea-reale
approved these changes
Nov 10, 2025
ntjohnson1
deleted the
antoine/rr-2819-fix-dataframe-query-empty-dataset
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related
What
Title. This was due to matching selectors to actual schema, which involved sorbet stuff, which failed on missing
RowIdcolumns. Fixed by short-circuiting the empty dataset case. Also added a test which, like many more, should have been here in the first place 🤦🏻