When closing recordings (and blueprints), drop them on separate threads for UI responsiveness.#11834
Merged
Wumpf merged 3 commits intorerun-io:mainfrom Nov 12, 2025
Merged
Conversation
emilk
added
📺 re_viewer
emilk
reviewed
Nov 10, 2025
Member
|
CI is unhappy because this code gets hit on wasm (gets correctly stuck in our disallowed method list for wasm) |
kpreid
force-pushed
the
drop-recording
branch
from
7af1ff2 to
721fb55
Compare
Contributor
Author
Whoops, I failed to notice that that lint was not a preexisting one but caused by my change, due to misreading what it was pointing at. The code already works as intended on wasm: the thread spawn returns an error, and this error is discarded, causing the store to be dropped on the current thread. I’ve added an |
This prevents the UI from hanging while dropping a large recording, which is useful when the user is trying to close multiple recordings at once. If threads are not available, automatically falls back to dropping on the current thread.
kpreid
force-pushed
the
drop-recording
branch
from
721fb55 to
f04c093
Compare
Wumpf
reviewed
Nov 11, 2025
Wumpf
reviewed
Nov 11, 2025
emilk
added
the
consider-patch
IsseW
pushed a commit
that referenced
this pull request
Nov 12, 2025
…ds for UI responsiveness. (#11834) Co-authored-by: Andreas Reich <r_andreas2@web.de>
IsseW
removed
the
consider-patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
StoreHub::remove_store(), execute drop of the store on a separate thread created for the purpose.This prevents the UI from hanging while dropping a large recording, which is useful when the user is trying to close multiple recordings at once.
If threads are not available, automatically falls back to dropping on the current thread.