Fix pressing the play button sometimes going to follow mode

[IsseW]

Related

• Part of Reconnecting with same rerun id #11585

What

Fixes a bug where pressing the play button in some contexts sometimes went to follow mode instead of playing mode.

[github-actions]

Web viewer built successfully.

Result	Commit	Link	Manifest
✅	9c8fafd	https://rerun.io/viewer/pr/11609	+nightly +main

View image diff on kitdiff.

^{Note: This comment is updated whenever you push a commit.}

[grtlr]

This looks suspicious (like we can't pause any more). There is probably a good reason for this, could we maybe document that?

[Wumpf]

so the bug was some timing issue in the command where toggle may cause issues somehow? Bit confused about why toggle doesn't work here. Also, isn't the play button changing its icon to pause... well clearly the code here is a pure play button as it always uses the icons::PLAY icon

[Wumpf]

right so actually we could pause with the play button here, that was actually nice. Do we have to break this?

[IsseW]

right so actually we could pause with the play button here, that was actually nice. Do we have to break this?

Yeah, I made that change some time ago. Before which it just switched to playing mode.

We could if we want to have a check like

if not playing mode {
	go to playing mode
} else {
	go to paused mode
}

[IsseW]

Bit confused about why toggle doesn't work here.

Toggle switches back to the last playing mode it seems, so if we were following last it switches to that.

[aedm]

Toggle switches back to the last playing mode it seems, so if we were following last it switches to that.

If we don't want that, we might fix it where it happens:

rerun/crates/viewer/re_viewer_context/src/time_control.rs

Line 1085 in aa97658

if self.following {

[IsseW]

Toggle switches back to the last playing mode it seems, so if we were following last it switches to that.

If we don't want that, we might fix it where it happens:

rerun/crates/viewer/re_viewer_context/src/time_control.rs

Line 1085 in aa97658

if self.following {

I think we do want that. When pressing space I think it makes sense to switch back to following at least

[Wumpf]

thx! 👍