Expose view container visibility in python blueprint api#11602
Conversation
IsseW
added
sdk-python
|
Web viewer built successfully.
View image diff on kitdiff. Note: This comment is updated whenever you push a commit. |
Wumpf
changed the title
Wumpf
left a comment
Wumpf
left a comment
There was a problem hiding this comment.
nice catch! Had no idea this was half-finished sitting around
Would be good to have some test coverage for container visibility, but I figure that's out of scope here 🤔
| .with_icon(icon_for_container_kind(&container_data.kind)) | ||
| .subdued(!container_data.visible) | ||
| .with_buttons(|ui| { | ||
| if !container_data.visible { |
There was a problem hiding this comment.
ohhh so if someone makes the root container invisible in blueprint, you make sure here to show that and give the user a way back? Would be good to comment the rationale here, took me a bit to understand what's going on
There was a problem hiding this comment.
Was confused because I do remember commenting that, it was just a bit below 😄 but yeah makes more sense to have the comment here
There was a problem hiding this comment.
ohhh so if someone makes the root container invisible in blueprint, you make sure here to show that and give the user a way back?
Exactly, I ran into this exact thing in my testing :D
Yeah I agree, I tried looking and it doesn't seem we even have any snippets for view visibility. Might also be nice to just have a snippet for just different containers in general? |
|
We could extend once it lands :) |
It landed and it adds finding a view by label. Also adds some panel drag&drop and resize tests if that's relevant. But I'd wait a bit until I implement #11628, the harness should be more convenient to use after that. |
3 participants
What
Exposes the visibility option to containers (Horizontal, Vertical, …) in the python api.