py-sdk: add register_prefix SDK call#11600
Merged
andrea-reale merged 2 commits intomainfrom Oct 27, 2025
Merged
Conversation
|
Web viewer built successfully.
View image diff on kitdiff. Note: This comment is updated whenever you push a commit. |
2e7d5ed to
3f24ef1
Compare
3f24ef1 to
531ced9
Compare
abey79
approved these changes
Oct 20, 2025
Member
abey79
left a comment
There was a problem hiding this comment.
Apart from the bikeshedding, this lgtm, thanks.
|
|
||
| """ | ||
|
|
||
| def register_prefix(self, recordings_prefix: str, recordings_layer: str | None = None) -> Tasks: |
Member
There was a problem hiding this comment.
I'm not sure about the signature, see slack thread.
Signed-off-by: Andrea Reale <[email protected]>
531ced9 to
206ee28
Compare
Signed-off-by: Andrea Reale <[email protected]>
206ee28 to
7229ee7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related
What
This PR builds up on the previous work and adds a new
register_prefixpythonSDK function that allows end-users to register all the recordings under a given
object store prefix (i.e., a directory).
Why
In a previous version of this change, we allowed users to register a prefix
simply by implicitly interpreting any trailing '/' in the object store URL as meaning
the customer wanted to register a prefix.
As debated in #11564, however, this is error prone, so we moved to requiring an explicit signal.
Instead of modifying the signature of the existing
register_batchfunction in non-obviousand possibly odd ways, I decided to add a new function that is explicit in its intent, that is.
register_prefix.FAQs
DataSourcesto be mixed in the same call. Why doesthe python SDK not allow this?
register_batchpython function signature more complex and awkward.This keeps the user surface simple, while leaving room for future improvements if needed.
register_prefixes(plural)?at once.
Testing
Manually