Reflection-based ROS2 parser now only returns single component#11480
Merged
Reflection-based ROS2 parser now only returns single component#11480
Conversation
|
Web viewer built successfully.
Note: This comment is updated whenever you push a commit. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the ROS2 reflection-based parser to consolidate all message fields under a single component named "message" instead of creating separate components for each field, making it easier to extract complete messages from lenses.
- Replaced individual field components with a single "message" component containing a struct
- Removed the empty message handling logic and associated helper function
- Updated the parser to use a single FixedSizeListBuilder with MessageStructBuilder
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
crates/utils/re_mcap/src/layers/ros2_reflection.rs |
Core parser logic updated to use single component structure |
tests/assets/rrd/snippets/howto/load_mcap.rrd |
Test asset updated with new binary hash/size |
crates/store/re_data_loader/tests/snapshots/test_mcap_loader__tests__ros2.snap |
Snapshot updated with new binary hash/size |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
grtlr
approved these changes
Oct 10, 2025
Member
grtlr
left a comment
There was a problem hiding this comment.
Nice, great to have this in line with protobuf parsing!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related
protobufparser only returns single component #11459)What
This changes our
ros2_reflectionparser to put the entire message behind a single component to make it easier to extract it from lenses.