Add context menu button to copy partition name#11378
Conversation
…u to loading partitions
IsseW
added
ui
|
Web viewer built successfully.
Note: This comment is updated whenever you push a commit. |
| let url = ViewerOpenUrl::from_data_source(receiver).and_then(|url| url.sharable_url(None)); | ||
| if ui | ||
| .add_enabled(url.is_ok(), egui::Button::new("Copy link to partition")) | ||
| .on_disabled_hover_text("Can't copy a link to this partition") |
There was a problem hiding this comment.
Should we print a reason? 🤔
I forget whether that was a well printable error or not
There was a problem hiding this comment.
We probably can, I'll try it
| if ui.button("Copy dataset name").clicked() { | ||
| re_log::info!("Copied {name:?} to clipboard"); | ||
| ui.ctx().copy_text(name.clone()); | ||
| } |
There was a problem hiding this comment.
I literally ran into it now that I needed to copy a dataset id rather than name and I couldn't do it from the web build linked by this PR.
That risk making it cluttery, but can we please also add that here?
|
partially offtopic to this PR, but we're strangle inconsistent of what type of URL we copy where. So for instanace this button But these give me it with it Tbh I'm not even sure which ones I expect where :/ |
- Copy with viewer url on dataset title copy button. - Show reason why a link can't be copied on hover. - Add copy dataset id button.
|
thanks! |
I think it's more that recently we've started adding viewer url if we're on web. But we should have this be consistent. Changed it to be the same in the title now. |
2 participants
Related
Closes RR-2412
What
Adds context menu button to partitions and datasets to copy their names. And adds the same context menu as partitions have to loading partitions.