Include "outer nullability" when we format column datatypes#11339
Merged
Include "outer nullability" when we format column datatypes#11339
Conversation
emilk
added
sdk-python
|
Web viewer built successfully.
Note: This comment is updated whenever you push a commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related
re(_arrow)_ui,codegenandre_format_arrow#11071What
We should be consistent and explicit when we format our datatypes - what can be nullable, and what cannot?
Most visibly, this will affect how dataframes are printed in our Python SDK.
I also discovered a bunch of places where we could be using the nice syntax-highlighting of
re_arrow_uibut aren't (yet). I marked those asTODO(#11071).This PR also surfaced a lack of snapshot testing: I would have expected to need to update some ui snapshot images but… no :/