Skip to content

Fix links to custom timelines#11333

Merged
Wumpf merged 3 commits intomainfrom
isse/fix-link-to-custom-timeline
Sep 25, 2025
Merged

Fix links to custom timelines#11333
Wumpf merged 3 commits intomainfrom
isse/fix-link-to-custom-timeline

Conversation

@IsseW
Copy link
Member

@IsseW IsseW commented Sep 24, 2025

Related

Closes #11191

What

Fixes opening links to custom timelines and adds UI to show that the timeline isn't there yet.

Screen.Recording.2025-09-24.at.18.03.27.mov

@IsseW IsseW added 🪳 bug Something isn't working 📺 re_viewer affects re_viewer itself include in changelog labels Sep 24, 2025
@github-actions
Copy link

github-actions bot commented Sep 24, 2025

Web viewer built successfully.

Result Commit Link Manifest
6aac1fc https://rerun.io/viewer/pr/11333 +nightly +main

Note: This comment is updated whenever you push a commit.

Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, this was a lot less invasive than thought it would be!

time: Option<re_log_types::TimeReal>,

/// If this is true the timeline will persist even if it is invalid at the moment.
pending: bool,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea to make this opt-in 💡

@Wumpf Wumpf merged commit 76629b9 into main Sep 25, 2025
69 of 70 checks passed
@Wumpf Wumpf deleted the isse/fix-link-to-custom-timeline branch September 25, 2025 16:51
@emilk emilk changed the title Fix links for custom timelines Fix links to custom timelines Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🪳 bug Something isn't working include in changelog 📺 re_viewer affects re_viewer itself

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Opening a link to a custom timeline doesn't work

2 participants