Better video stream errors for missing samples & key frames#11310
Merged
Conversation
Wumpf
added
📺 re_viewer
|
Web viewer built successfully.
Note: This comment is updated whenever you push a commit. |
IsseW
approved these changes
Sep 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we'd fairly eagerly showed "no video data" when in actually there was data, just not enough for decoding. This can happen a lot when cutting chunks or sending incomplete data.
Examples
No key frames at all, but some samples:
No key frames prior to what we're looking at (there's some later on and as expected the video plays then):
