Skip to content

Fix rare issue where video stream sample indices would be determined incorrectly, breaking video inspection UI & playback#11308

Merged
Wumpf merged 1 commit intomainfrom
andreas/fix-video-stream-sample-indices
Sep 23, 2025
Merged

Fix rare issue where video stream sample indices would be determined incorrectly, breaking video inspection UI & playback#11308
Wumpf merged 1 commit intomainfrom
andreas/fix-video-stream-sample-indices

Conversation

@Wumpf
Copy link
Member

@Wumpf Wumpf commented Sep 23, 2025

This is fairly difficult to hit in the wild, but would happen when receiving chunks that for some reason either:

  • have unused extra data in their video sample component array
  • have video sample components that are used only on some arrays

I've hit this on on my ongoing chunk cropping PR because at the moment the cropping doesn't necessarily discard underlying sample data, causing previously unexpected array offsets.

@Wumpf Wumpf added 🪳 bug Something isn't working 📺 re_viewer affects re_viewer itself include in changelog feat-video anything video decoding, player, querying, data modelling of videos etc. labels Sep 23, 2025
@github-actions
Copy link

github-actions bot commented Sep 23, 2025

Web viewer built successfully.

Result Commit Link Manifest
b937ecb https://rerun.io/viewer/pr/11308 +nightly +main

Note: This comment is updated whenever you push a commit.

@Wumpf Wumpf merged commit a339212 into main Sep 23, 2025
50 checks passed
@Wumpf Wumpf deleted the andreas/fix-video-stream-sample-indices branch September 23, 2025 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🪳 bug Something isn't working feat-video anything video decoding, player, querying, data modelling of videos etc. include in changelog 📺 re_viewer affects re_viewer itself

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants