Fix incorrect application id when dragging and dropping files#11197
Merged
Fix incorrect application id when dragging and dropping files#11197
Conversation
oxkitsune
added
🪳 bug
|
Web viewer built successfully.
Note: This comment is updated whenever you push a commit. |
abey79
approved these changes
Sep 12, 2025
Member
|
Still seeing some problems. Will add more details here after standup. |
oxkitsune
force-pushed
the
gijs/fix-application-id-web
branch
from
4b968f2 to
f281b5f
Compare
emilk
approved these changes
Sep 15, 2025
Member
emilk
left a comment
emilk
left a comment
There was a problem hiding this comment.
Code LGTM, but I haven't tested it.
grtlr
approved these changes
Sep 15, 2025
oxkitsune
changed the title
aedm
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
When drag-and-dropping a file into the web viewer, we only get the file name not the full path. This results in the store being created with a random application id.
This makes the picked application id fall back to the file name, if there's no file path available.