Conversation
IsseW
added
🪳 bug
|
Web viewer built successfully.
Note: This comment is updated whenever you push a commit. |
| /// True if this fragment doesn't contain any information. | ||
| pub fn is_empty(&self) -> bool { | ||
| // Keep this as a destruction so there is a compile error if a new field isn't handled here. | ||
| let Self { selection, when } = self; |
Wumpf
left a comment
Wumpf
left a comment
There was a problem hiding this comment.
tested the change cross web browsers & native. works smoothly now ✨
code looks great as well!
This adds the variant SetFragment to UiCommand in crates/store/re_redap_client/src/grpc.rs, which I'm pretty sure is a breaking change (according to semver).
correct, struggling with this fact a lot on wgpu...
But no worries we bump the version number of all crates in the workspace on every release regardless of changes
Also adds a system command SetFragment, which creates other system commands when invoked. Which might be the first system command which does that? The system command loop looks like it's made to handle that though
ack, should be fine. But also I don't think it's the first :)
IsseW
force-pushed
the
isse/fix-loading-selection-fragment
branch
from
1168924 to
93e8c60
Compare
### Related - Closes RR-2222 - Based on #11153 because I made some changes there that would conflict with this otherwise. ### What Fixes selection sharing, which before this was only applied too early to actually affect the selection. This adds the variant `SetUrlFragment` to `UiCommand` in `crates/store/re_redap_client/src/grpc.rs`, which I'm pretty sure is a breaking change (according to semver). Also adds a system command `SetUrlFragment`, which creates other system commands when invoked. Which might be the first system command which does that? The system command loop looks like it's made to handle that though.
2 participants
Related
What
Fixes selection sharing, which before this was only applied too early to actually affect the selection.
This adds the variant
SetUrlFragmenttoUiCommandincrates/store/re_redap_client/src/grpc.rs, which I'm pretty sure is a breaking change (according to semver).Also adds a system command
SetUrlFragment, which creates other system commands when invoked. Which might be the first system command which does that? The system command loop looks like it's made to handle that though.