Skip to content

Fix unnecessary rfd and wayland dependencies in SDK crate#10802

Merged
Wumpf merged 3 commits intomainfrom
andreas/fix-ui-deps-leaking-into-sdk
Aug 6, 2025
Merged

Fix unnecessary rfd and wayland dependencies in SDK crate#10802
Wumpf merged 3 commits intomainfrom
andreas/fix-ui-deps-leaking-into-sdk

Conversation

@Wumpf
Copy link
Member

@Wumpf Wumpf commented Aug 5, 2025

Related

What

Adds a test to detect this kind of thing. The test is fairly quick to run and is part of all CI subsets that run Rust checks.

@Wumpf Wumpf added this to the 0.24.1 - bug fixes milestone Aug 5, 2025
@Wumpf Wumpf added 🪳 bug Something isn't working sdk-rust Rust logging API include in changelog labels Aug 5, 2025
@Wumpf Wumpf force-pushed the andreas/fix-ui-deps-leaking-into-sdk branch from 13029de to 453674a Compare August 5, 2025 16:20
@github-actions
Copy link

github-actions bot commented Aug 5, 2025

Latest documentation preview deployed successfully.

Result Commit Link
e685a8e https://landing-bvwbj1c6c-rerun.vercel.app/docs

Note: This comment is updated whenever you push a commit.

@github-actions
Copy link

github-actions bot commented Aug 5, 2025

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
e685a8e https://rerun.io/viewer/pr/10802 +nightly +main

Note: This comment is updated whenever you push a commit.

Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

It would be nice to see a red CI on the first build step before you committed the fix, but I assume you at least ran the new test locally first?

@Wumpf
Copy link
Member Author

Wumpf commented Aug 6, 2025

but I assume you at least ran the new test locally first?

yup!

@emilk emilk mentioned this pull request Aug 6, 2025
9 tasks
@Wumpf Wumpf merged commit d4c6be1 into main Aug 6, 2025
80 of 84 checks passed
@Wumpf Wumpf deleted the andreas/fix-ui-deps-leaking-into-sdk branch August 6, 2025 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🪳 bug Something isn't working include in changelog sdk-rust Rust logging API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rust SDK depends on rfd (file dialog library)

2 participants