Skip to content

Comments

Allow root space views transforms to other roots#1075

Merged
Wumpf merged 4 commits intomainfrom
andreas/root-transforms
Feb 3, 2023
Merged

Allow root space views transforms to other roots#1075
Wumpf merged 4 commits intomainfrom
andreas/root-transforms

Conversation

@Wumpf
Copy link
Member

@Wumpf Wumpf commented Feb 3, 2023

It's now possible to add arbitrary entity paths to any space view!

also:

  • Fixed issues with incorrect reachability detection in SpaceInfo
  • Better group names for this new reality

Two different sub spaceviews from the planetary demo with everything added that can be added (single click in the picker!)
image

Demo of the madness one can create with this (prior to group improvements)

Screen.Recording.2023-02-03.at.11.42.08.mov

Fixes most of #1060, some stuff left regarding naming. 2D categorization probably dropped for now

Left todos:

  • better space view naming
  • heuristic for root space path?
  • use root space path in colmap

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I've added a line to CHANGELOG.md (if this is a big enough change to warrant it)

Wumpf added 2 commits February 3, 2023 11:24
Fix bug in space info reachability check (which drives the entity picker)
@Wumpf Wumpf marked this pull request as draft February 3, 2023 10:56
@Wumpf Wumpf marked this pull request as ready for review February 3, 2023 13:25
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay!

@Wumpf Wumpf merged commit ba4722a into main Feb 3, 2023
@Wumpf Wumpf deleted the andreas/root-transforms branch February 3, 2023 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants