Introduce RecordingOpen viewer event#10654
Conversation
jprochazk
commented
Jul 15, 2025
|
Latest documentation preview deployed successfully.
Note: This comment is updated whenever you push a commit. |
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
| let entity_db = store_hub.entity_db_mut(store_id); | ||
| let is_new_store = matches!(&msg, LogMsg::SetStoreInfo(_msg)); | ||
| if is_new_store && entity_db.store_kind() == StoreKind::Recording { | ||
| if msg_will_add_new_store && entity_db.store_kind() == StoreKind::Recording { |
There was a problem hiding this comment.
Before, this was firing off the event twice... Which is really strange. I didn't investigate too deeply, I changed it to check not only that it's a SetStoreInfo message, but also that the store actually doesn't exist yet. That fixed it for me. I assume the root cause is that we are sending multiple store info messages somewhere.
There was a problem hiding this comment.
huh, that's a bit worrisome 🤔
but your check makes sense regardless
Wumpf
left a comment
There was a problem hiding this comment.
seems low risk enough to add it to 0.24 last minute. Liking the doc strings very much, thanks!