Dynamically Set Active Partition URL and Select Time Window#10557
Conversation
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
jprochazk
left a comment
There was a problem hiding this comment.
Lint stuff LGTM
What do you think about exposing open and close directly? I feel like users should be able to open more than one partition URL at a time. Not just partition URLs, but any data source.
Review comments are mostly about where open_url would fit in
(I'd be happy to do that work myself as a follow-up)
| _width = traitlets.Int(allow_none=True).tag(sync=True) | ||
| _height = traitlets.Int(allow_none=True).tag(sync=True) | ||
|
|
||
| # TODO(nick): This traitlet is only used for initialization |
There was a problem hiding this comment.
We could achieve this by calling open_url in the constructor. We'd need to ensure that events sent before the Viewer is ready are buffered like data with _data_queue.
At that point having another queue doesn't seem great, because data, tables, and other events all go through the same interface. We should have a single _event_queue and a helper (_send_buffered or something) to push data into it, or send it directly depending on if the Viewer is ready yet.
|
As you can see I ran into a bit of a headache with CI. I'm punting on open_url for follow up. If you have bandwidth to pick it up that'd be great. Otherwise we can probably check in tomorrow. |
What
set_active_partition_urlon the viewer aligned withset_active_recording_idto dynamically toggle thatdataset.partition_urlto take in arguments that can constrain the observed time windowpixi run fast-lintapparently linux users haven't seen these issues even though I think they are actual bugs