Fix spurious decode errors with H.264 on native Viewer#10539
Merged
Conversation
Contributor
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
emilk
approved these changes
Jul 8, 2025
Member
Author
|
the new tests are very unhappy about this? Needs a closer look. |
Member
Author
|
ah ofc, the ones where we don't have a decoder bail now. Need to make the redraw condition more fine grained! good test! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes a previous attempt for lower latency that caused spurios decode errors, observed with ffmpeg 7.1 on Mac & Windows.
Also, fix retry-on-error condition: we were checking for the wrong kind of error in
VideoPlayerError::should_request_more_frames.This improves pausing on corrupt video data which sometimes may recover on decoder restarts.