Skip to content

Fix spurious decode errors with H.264 on native Viewer#10539

Merged
Wumpf merged 4 commits into
mainfrom
andreas/video/fix-spurious-decode-errors
Jul 8, 2025
Merged

Fix spurious decode errors with H.264 on native Viewer#10539
Wumpf merged 4 commits into
mainfrom
andreas/video/fix-spurious-decode-errors

Conversation

@Wumpf
Copy link
Copy Markdown
Member

@Wumpf Wumpf commented Jul 8, 2025

Removes a previous attempt for lower latency that caused spurios decode errors, observed with ffmpeg 7.1 on Mac & Windows.

Also, fix retry-on-error condition: we were checking for the wrong kind of error in VideoPlayerError::should_request_more_frames.
This improves pausing on corrupt video data which sometimes may recover on decoder restarts.

@Wumpf Wumpf added 🪳 bug Something isn't working include in changelog feat-video anything video decoding, player, querying, data modelling of videos etc. labels Jul 8, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 8, 2025

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
93638bc https://rerun.io/viewer/pr/10539 +nightly +main

Note: This comment is updated whenever you push a commit.

@Wumpf
Copy link
Copy Markdown
Member Author

Wumpf commented Jul 8, 2025

the new tests are very unhappy about this? Needs a closer look.

@Wumpf
Copy link
Copy Markdown
Member Author

Wumpf commented Jul 8, 2025

ah ofc, the ones where we don't have a decoder bail now. Need to make the redraw condition more fine grained!

good test! :)

@Wumpf Wumpf merged commit f2fabb8 into main Jul 8, 2025
38 checks passed
@Wumpf Wumpf deleted the andreas/video/fix-spurious-decode-errors branch July 8, 2025 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🪳 bug Something isn't working feat-video anything video decoding, player, querying, data modelling of videos etc. include in changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants