Fix integer overflow in TimeSeriesView for too large timestamps#10310
Merged
Conversation
oxkitsune
added
🪳 bug
oxkitsune
changed the title
saturating_add when adding nanos in TimeSeriesViewsaturating_add in timestamp rounding for TimeSeriesView
Contributor
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
Wumpf
approved these changes
Jun 19, 2025
Member
Wumpf
left a comment
Wumpf
left a comment
There was a problem hiding this comment.
lgmtwhatcouldpossiblygowrong :)
Wumpf
changed the title
saturating_add in timestamp rounding for TimeSeriesViewTimeSeriesView for too large timestamps
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This avoids overflow of timestamps in the
TimeSeriesView