Log a warning when starting the viewer from inside a Docker container#10306
Conversation
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
5ab8ed3 to
a1f3c64
Compare
|
@abey79 this is good for landing but simply nobody tested it? |
I think so yes? I sure didn't test it. |
|
dedusted my docker windows install, having it run in the background and do some building |
|
okay apparently running a graphical linux container on a windows host is pita. Someone with native Linux should try it |
|
@jleibs volunteered to give it a spin |
There was a problem hiding this comment.
unfortunately nobody on the team who tried has been able to actually run Rerun in their Docker environments so far (not that we tried a lot)
Looking over the changes this looks benign enough to ship it anyways. Don't see how this could cause issues and even if there were false positives it's not a problem
|
### Related * Follow-up to #10306 ### What We would already print a warning to the terminal, but now we also show it in the notification panel (and as a toast/popup): <img width="448" height="241" alt="Screenshot 2025-08-04 at 11 03 47" src="https://github.com/user-attachments/assets/662bc96e-d366-4ef6-a555-fb92c6921f6f" />
### Related * Follow-up to #10306 ### What We would already print a warning to the terminal, but now we also show it in the notification panel (and as a toast/popup): <img width="448" height="241" alt="Screenshot 2025-08-04 at 11 03 47" src="https://github.com/user-attachments/assets/662bc96e-d366-4ef6-a555-fb92c6921f6f" />

Running the Rerun Viewer from inside a docker container has several problems:
So let's at least warn the user that this is a bad idea!
I also added
is_dockerto our analytics events so we can see how common this is amongst our users.Related
TODO