Add catalog entry table#10290
Conversation
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
lucasmerlin
added
enhancement
lucasmerlin
force-pushed
the
lucas/catalog-table
branch
from
6df16fc to
a846673
Compare
Wumpf
left a comment
Wumpf
left a comment
There was a problem hiding this comment.
understanding a bit too little about the envisioned architecture here to gauge whether it's the right call to extend the table blueprint and the data fusion query data like this, but looks great otherwise! :)
| global_ctx.command_sender.send_system( | ||
| SystemCommand::ChangeDisplayMode(DisplayMode::RedapServer(origin)), | ||
| ); |
| _component_descriptor: &ComponentDescriptor, | ||
| _row_id: Option<RowId>, | ||
| data: &dyn arrow::array::Array, | ||
| ) -> Result<(), Box<dyn Error>> { |
There was a problem hiding this comment.
out of scope of this pr, but annoys me that this is boxed error. might just as well be anyhow but I bet it's not that diverse in regards of error types and could be thiserror
That's kind of what I alluded at during yesterday's standup. We need table-blueprint-y stuff but we don't yet have a well established frame for building this. So it happens organically and is occasionally weird. Another way to put it is that we're building hindsight that will help future designs 🤷🏻 |
3 participants
Related
What
Uses the datafusion table to show a table of entries for the whole catalog.