Skip to content

Toggle maximized view with Ctrl+M#10162

Merged
emilk merged 4 commits into
mainfrom
emilk/toggle-maximize-shortcut
Jun 9, 2025
Merged

Toggle maximized view with Ctrl+M#10162
emilk merged 4 commits into
mainfrom
emilk/toggle-maximize-shortcut

Conversation

@emilk
Copy link
Copy Markdown
Member

@emilk emilk commented Jun 8, 2025

What

This adds a keyboard shortcut for toggling the currently selected view as maximized or not.

Questions

  • Should we toggle the selected view, or the one currently hovered by the mouse?

@emilk emilk added ui concerns graphical user interface include in changelog labels Jun 8, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 8, 2025

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
0b0f81e https://rerun.io/viewer/pr/10162 +nightly +main

Note: This comment is updated whenever you push a commit.

@emilk emilk changed the title Toggle maximized view with ⌘+M or Ctrl+M Toggle maximized view with Ctrl+M Jun 8, 2025
Copy link
Copy Markdown
Member

@jprochazk jprochazk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current behavior seems good to me. Click somewhere in the view, then ctrl+m

@emilk emilk merged commit d7aca63 into main Jun 9, 2025
37 of 38 checks passed
@emilk emilk deleted the emilk/toggle-maximize-shortcut branch June 9, 2025 16:27
emilk added a commit that referenced this pull request Jun 9, 2025
### Related
* Builds on #10162

### What
Animate the maximization/restoration of a view.
This helps the user stay oriented ("where did that view go…")



https://github.com/user-attachments/assets/ccd754e5-b9c6-4245-a438-fbe669116c5d

(The animation is much smoother in real life)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

include in changelog ui concerns graphical user interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants