Skip to content

Switch icons to .svg#10055

Merged
emilk merged 15 commits into
mainfrom
emilk/svg-icons
May 27, 2025
Merged

Switch icons to .svg#10055
emilk merged 15 commits into
mainfrom
emilk/svg-icons

Conversation

@emilk
Copy link
Copy Markdown
Member

@emilk emilk commented May 23, 2025

Related

What

Replaces all .png icons for .svg

The apparent differences are pretty minor, but in some situations the results should be slightly less blurry.

TODO

  • Fix the icons in Figma so that they are 14x14 when exported, instead of 14x15 (@gavrelina 🙏 )
  • Figure out why they appear more blurry than the .png:s 😬 (maybe it's the above thing?)
  • Add missing SVG:s not found in the "Latest icons" section on Figma (@gavrelina 🙏)
    • bottom_panel_toggle
    • breadcrumbs_separator
    • data_source
    • discord
    • dnd_handle
    • left_panel_toggle
    • notification
    • rerun_io
    • rerun_menu
    • right_panel_toggle
    • settings
    • video_error

@emilk emilk added ui concerns graphical user interface 📺 re_viewer affects re_viewer itself exclude from changelog PRs with this won't show up in CHANGELOG.md labels May 23, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 23, 2025

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
b550684 https://rerun.io/viewer/pr/10055 +nightly +main

Note: This comment is updated whenever you push a commit.

@gavrelina
Copy link
Copy Markdown
Member

Added missing icons in Figma section.

NB:

  • panels + notification are 16x16 not 14x14
  • added rerun logo in 24x24 and 16x16
  • added video error in 40x40 and 16x16 (as it's used in ~40x40)
  • Icon/data_source SAME as Icon/external_link, so maybe rather change in code

@emilk emilk force-pushed the emilk/svg-icons branch from 14c3503 to 1421e33 Compare May 27, 2025 13:36
@emilk emilk marked this pull request as ready for review May 27, 2025 13:37
@Wumpf
Copy link
Copy Markdown
Member

Wumpf commented May 27, 2025

difference is huge if you set your viewer to huge! Enabling changelog on this!

image image

One interesting detail here: was the rerun menu icon supposed to be bigger?

@Wumpf Wumpf added include in changelog and removed exclude from changelog PRs with this won't show up in CHANGELOG.md labels May 27, 2025
Copy link
Copy Markdown
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah actually that menu regressed quite a bit, misses the arrow as well! Should fix that before landing. otherwise great!

before:
image

after:
image

@emilk emilk requested a review from Wumpf May 27, 2025 16:56
@emilk
Copy link
Copy Markdown
Member Author

emilk commented May 27, 2025

Fixed (by reverting the icon):
image

@emilk emilk merged commit 5d3a1b8 into main May 27, 2025
40 checks passed
@emilk emilk deleted the emilk/svg-icons branch May 27, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

include in changelog 📺 re_viewer affects re_viewer itself ui concerns graphical user interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Future strategy for icon management

3 participants