Add support for variant UIs in the DataFusion table widget and show a button in the partition table recording links#10035
Conversation
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
abey79
added
ui
Wumpf
left a comment
Wumpf
left a comment
There was a problem hiding this comment.
much better groundwork :)
being fairly new to this area one thing that confuses me a bit is the relationship between ComponentDescriptor and ColumnDescriptor for a single row. Maybe something you can walk me through briefly later.
| data_to_display.as_ref(), | ||
| ); | ||
| if let Some(variant_name) = self.variant_name { | ||
| ctx.component_ui_registry().variant_ui_raw( |
There was a problem hiding this comment.
looking at the other pr the variant ui raw method does fallbacks to non-variant driven ui. Given that, could we just pass in the option to variant_ui_raw?
Seems like a good datapoint for taking an option on variant_ui and then use component name if no variant is there and automatically fallback? 🤔
But yeah asking for a variant and not getting one is more of a bug as you noted on the other pr
With pleasure! |
abey79
force-pushed
the
antoine/table-widget-variant-support
branch
from
f356847 to
07ba4c2
Compare
- Introduce `ColumnBlueprint` - Currently only provided via a closure - Now `DisplayRecordBatch` takes a `ColumnBlueprint` Adjust for `VariantName`
abey79
force-pushed
the
antoine/table-widget-variant-support
branch
from
07ba4c2 to
10d596d
Compare
2 participants
Related
DataFusionTableWidget#9795re_component_ui#10034What
This PR introduces the ability to specify on a per-column basis a specific variant ui (see #10034) to use. To that end, a new
ColumnBlueprintstructure is introduced and a bunch of things around that is refactored.This PR also uses the recently introduced
redap_urlvariant UI to display the recording link as an "open" button instead of a fully URL.