Fix: WsEvent::Closed is correctly sent on web when socket is closed.#6
Merged
Conversation
Member
|
I'm updating to 1.65 to fix the CI issues: #7 |
Member
|
Try merging in |
Member
|
Please add a line to |
Contributor
Author
I have updated CHANGELOG.md and the version, I wasn't sure if I needed to add that under |
emilk
approved these changes
Nov 21, 2022
Member
|
It should go under |
emilk
reviewed
Nov 21, 2022
emilk
reviewed
Nov 21, 2022
emilk
changed the title
WsEvent::Closed is correctly sent on web when socket is closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have noticed that when a Websocket server closes the connection the client wasn't getting a close notification, this PR adds a close callback so that the event is propagated to the UI: