Fix sum(memoryAllocatable) and sum(podAllocatable) #180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove repetition across test cases that made it hard to read. Tweaks tests where needed so they can all use the same node data. Also corrects a test where the description didn't match the test.
Fixes `sum(memoryAllocatable)` and `sum(podAllocatable)`. These previously tested the wrong resource (cpuAllocatable). Also refactor comparison functions to unify resolving properties and add more testing. Fixes replicatedhq#179.
Contributor
|
Thanks @MikaelSmith ! @marccampbell do you know who might be the best person to review this? |
laverya
approved these changes
May 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
sum(memoryAllocatable)andsum(podAllocatable). These previously tested the wrong resource (cpuAllocatable).Also refactor comparison functions to unify resolving properties and add more testing.
Fixes #179.