fix(host-preflights): builtin kernel modules file from wrong path #1741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squizzi
reviewed
Feb 18, 2025
squizzi
previously approved these changes
Feb 18, 2025
Member
squizzi
left a comment
squizzi
left a comment
There was a problem hiding this comment.
lgtm, just a nit on logging the directories checked.
|
|
||
| kernelPath := filepath.Join("/lib/modules", kernelRelease) | ||
| if _, err := os.Stat(kernelPath); os.IsNotExist(err) { | ||
| klog.V(2).Infof("modules are not loadable because kernel path %q does not exist, assuming we are in a container", kernelPath) |
Member
There was a problem hiding this comment.
nit: It might be worth logging in this instance that /lib/modules does not exist, checking /usr/lib/modules before the assuming we are in container log fires, because that makes it sound like we only ever checked /usr/lib/modules.
Or maybe update the kernelPath in Infof to be:
klog.V(2).Infof("modules are not loadable because kernel path %q or %q do not exist, assuming we are in a container", kernelPathLib, kernelPathUsr)
Member
Author
There was a problem hiding this comment.
updated to print the expected path
laverya
changed the title
laverya
changed the title
laverya
approved these changes
Feb 18, 2025
emosbaugh
deleted the
emosbaugh/20250218/builtin-kernel-modules-debian
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description, Motivation and Context
Path is wrong for some systems.
Checklist
Does this PR introduce a breaking change?