Skip to content

refactor byte array interfaces #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
laverya merged 3 commits into from
Apr 14, 2020
Merged

refactor byte array interfaces #172

laverya merged 3 commits into from
Apr 14, 2020

Conversation

@laverya
Copy link
Member

@laverya laverya commented Apr 14, 2020

returning []byte instead of map[string][]byte is pointless and introduces significant code complexity

(also, more than half of the existing collectors were just marshalling map[string][]byte anyways)

@laverya laverya requested a review from divolgin April 14, 2020 21:59
@laverya laverya merged commit f06cd9e into master Apr 14, 2020
@laverya laverya deleted the laverya/refactor-byte-array-interfaces branch April 14, 2020 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@divolgin divolgin divolgin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@laverya @divolgin